-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: view for go env
and important settings that affects go's functionality
#2049
Comments
Of course, this is not the first time I thought about this :-) #1630 |
Change https://go.dev/cl/388754 mentions this issue: |
Change https://go.dev/cl/388435 mentions this issue: |
Change https://go.dev/cl/389454 mentions this issue: |
Adds a tree view for Go to the explorer. Initially the view contains only select entries about the go env settings for the currently open workspace and file - GOPRIVATE, GOMOD, GOWORK, GOENV, and any value set with toolsEnvVars from the go workspace configuration. Snapshot: https://drive.google.com/file/d/1q0whHB5wSV0Q_pzMr9TM1-E7GxRE5zru/view?usp=sharing For #2049 Change-Id: I5c5f78913626f5f6d59de90368fff4bd5ffcb33e Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/388435 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Added a tree item to the Go explorer view that displays the status and version detail of installed tools. Snapshot: https://drive.google.com/file/d/17s1qWzl-7slTHLIfovfNZqQERveVVcAN/view?usp=sharing For #2049 Change-Id: I074a4a087db56e5e0cdcfcf8a90d234d083dc483 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/388754 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Polina Sokolova <polina@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
For #2049 Change-Id: I5b66e4565f0d615a6cff31677981913a3e02d4b7 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/389454 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
Change https://go.dev/cl/391254 mentions this issue: |
Change https://go.dev/cl/391255 mentions this issue: |
Change https://go.dev/cl/391256 mentions this issue: |
If a user drags the explorer from the default location to the activitybar, the Go logo will appear instead of the default file icon. Snapshot: https://drive.google.com/file/d/1uSF4qIp5yHFPZEpOOT9xLVq3g_0LjJPf/view For #2049 Change-Id: I8647485cfaf6c71560ed1eac6ee0f9cc8b81afa7 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391254 Trust: Jamal Carvalho <jamal@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
For #2049 Change-Id: Idc23f0b10263d1988a1a20fe619a6a8ebc73b2d2 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391255 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
For #2049 Change-Id: Iaa4c5cf67d44f97f8fe4bd0e49a897cc5d4d9624 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391256 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
Change https://go.dev/cl/391515 mentions this issue: |
Added commands for editing and resetting go env values. The commands are available from the command palette or as context items within the explorer view. When invoked from the explorer on an env tree item, the command will apply only to that item. The edit command invoked from the palette will present the user with a list of editable go env variables. Screencast: https://drive.google.com/file/d/19KcTYcYACpL-8R5pW9z_XMaaCnliqSZj/view?usp=sharing For #2049. Change-Id: Ic13944437f300d3616d8b98533842c4da914c080 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391515 Trust: Jamal Carvalho <jamal@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
From v0.33.0, there will be a Go view in the Explorer container by default and that will present some environment variables and tool locations and versions. We plan to extend this to provide easy access to update the env vars or flag variables in the future. Users can move the view to the activity bar directly, move to bottom of the editor, or completely hide it like other views. Thanks @jamalc |
Should |
There are dozens of settings and environment variables affecting how
go
command works.go env
or commands to inspect environment variables is a typical way to inspect them,but often the environment the extension (or vscode extension host) is different from what
users see from their terminals (e.g. users use shell config that does not get invoked when
vscode launches, etc.). That causes confusions numerous times.
We added some of the info in the
Go: Locate Configured Tools
command output, butthe output is verbose and text-heavy. It's time to think about better UI. An option is View.
Info to included in the new Go Env view
go env
output...
Future work
This view may be extended in the future to have associated commands
go.mod
file)Remarks
The info in the view may need to change depending on the workspace root folder the open file belongs to.
I cannot think of a good existing default container (explorer/scm/debug/test) where this new view belongs to yet. We may need to create a custom view container for Go - where we can organize more go-project specific information (Module/Package dependencies, Package doc, ...)
cc @jamalc @golang/tools-team
The text was updated successfully, but these errors were encountered: