Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a test for file watching API with gopls #404

Open
stamblerre opened this issue Jul 25, 2020 · 4 comments
Open

test: add a test for file watching API with gopls #404

stamblerre opened this issue Jul 25, 2020 · 4 comments
Labels
chore/testing issues related to bugs in test, CI setup
Milestone
vscode-go/unplanned

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Jul 25, 2020 •
edited
Loading

A file watching integration test would be really useful, since the LSP file watching API is based on VS Code's.
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/244605 mentions this issue: internal/lsp: fix GlobPattern for watching files

gopherbot pushed a commit to golang/tools that referenced this issue Jul 25, 2020
@stamblerre
internal/lsp: fix GlobPattern for watching files
102e7d3 
I noticed this wasn't working correctly when debugging issues with file
changes on disk. I think I misunderstood how to correctly match on
zero or more path segments. Confirmed that this is working as expected
with VS Code, but we really need regression tests for this in VS Code
(it seems to be based directly on VS Code's API). Filed
golang/vscode-go#404.

Change-Id: Ib906f73a97317dfa9bd30099877c90d4072651cc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244605
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@hyangah hyangah mentioned this issue Jul 31, 2020
Closed
@hyangah hyangah added this to the Backlog milestone Aug 7, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/247684 mentions this issue: internal/lsp: lowercase drive letters on Windows to fix file watching

gopherbot pushed a commit to golang/tools that referenced this issue Aug 12, 2020
@stamblerre
internal/lsp: lowercase drive letters on Windows to fix file watching
3986990 
This is a work-around for
microsoft/vscode#104387. We now always
lowercase the drive letter on Windows.

This CL also fixes a bug introduced by CL 245327, which caused URIs
to be used instead of paths in the GlobPattern.

We really need VS Code integration tests for this
(golang/vscode-go#404).

Updates golang/go#40661

Change-Id: I21be6d929288cfe41168cea34001fc2f41ac6c8b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/247684
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/251081 mentions this issue: test/gopls: add integration tests for file watching on-disk

@stamblerre stamblerre added the chore/testing issues related to bugs in test, CI setup label Nov 10, 2020
@stamblerre
Copy link
Contributor Author

Removing this from the vscode-go: gopls by default project because this is not a blocker, though we should have these tests in place before (if ever) gopls changes the file watching glob patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore/testing issues related to bugs in test, CI setup
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot