Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate compatibility with live share #605

Closed
hyangah opened this issue Sep 3, 2020 · 7 comments
Closed

Investigate compatibility with live share #605

hyangah opened this issue Sep 3, 2020 · 7 comments
Labels
FrozenDueToAge
Milestone
v0.20.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 3, 2020 •
edited
Loading

We've received multiple user requests and crash reports related to VS Code Live Share

https://code.visualstudio.com/blogs/2017/11/15/live-share
https://github.com/MicrosoftDocs/live-share

Many tools this extension depend on assumes all files in the repo are
accessible with usual file API, outside VS Code. We are not yet sure
how they would work with Live Share yet.
@hyangah hyangah mentioned this issue Sep 3, 2020
Closed
@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 3, 2020
@hyangah hyangah added this to the Backlog milestone Sep 3, 2020
@hyangah hyangah mentioned this issue Oct 25, 2020
Closed
@hyangah
Copy link
Contributor Author

hyangah commented Oct 25, 2020

Let's make sure to discuss this before turning on gopls by default (even though I don't think gopls is the only part that doesn't support live share now).

@hyangah
Copy link
Contributor Author

hyangah commented Nov 10, 2020

I just tried it and it looks like all the computation occurs on the server-side (i.e. gopls on the host's machine).
All other participants can simply turn off (iow disable) vscode-go extension during the session.

@stamblerre
Copy link
Contributor

Should the extension disable itself if it encounters VSLS URIs or should users do that manually?

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/269157 mentions this issue: src/goLanguageServer: process only file, untitled doc schemes

@hyangah hyangah mentioned this issue Nov 11, 2020
Closed
gopherbot pushed a commit that referenced this issue Nov 11, 2020
@hyangah
src/goLanguageServer: process only file, untitled doc schemes
b2a6198 
As recommended in https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/extensions#visual-studio-code-1
Even when gopls could handle vsls:/, that wouldn't be desirable -
the language servers in both host and guest machines would
work and produce duplicate results.

For #605

Change-Id: I953a81713be5e65a8b8e1597390b50a69ec4eed8
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/269157
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah modified the milestones: Backlog, v0.19.0 Nov 17, 2020
@hyangah hyangah removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 20, 2020
@hyangah
Copy link
Contributor Author

hyangah commented Nov 25, 2020

I confirmed now the extension doesn't complain about gopls's crashes on the live share guest side.
Most of intellisense features offered by the language server and some features like adding tags, etc are working as expected. Some of the code lenses, debug features are not available without host's configuration, but it's also working as intended.

I will close this issue for now. As we find individual issues, we will address them in separate issues.

Thanks for being patient. The feature is available in v0.19.0.

@hyangah hyangah closed this as completed Nov 25, 2020
@hyangah
Copy link
Contributor Author

hyangah commented Dec 11, 2020

Strange - when I tested, it worked. Now I can reproduce this issue again.
The language client library is still sending the initialization request with vsls: URI and gopls is unhappy about it of course.

@hyangah hyangah reopened this Dec 11, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/277392 mentions this issue: src/goLanguageServer: disable language service on guest side completely

@hyangah hyangah modified the milestones: v0.19.0, v0.20.0 Dec 21, 2020
@golang golang locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot