src/debugAdapter: suppress error pop-up for failed watch expression evaluation #196
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: bf1ce35) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/236999 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
This PR (HEAD: 3f528ce) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/236999 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
This PR (HEAD: 9a52492) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/236999 to see it. Tip: You can toggle comments from me using the |
|
Message from Polina Sokolova: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
Message from Rebecca Stambler: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
Message from Hyang-Ah Hana Kim: Patch Set 3: Code-Review+2 Thanks - and the lint error was posted in the checks linked in the github PR. Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
Message from Polina Sokolova: Patch Set 3:
Yup, I did see it in the morning when I logged on again, but not in the middle of the night when I was in a hurry to go to bed. There is often a lag with these checks, and it is easy to forget to come back to check. Hence the suggestion to also explicitly make this part of preparing the PR for review. Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
|
Message from Rebecca Stambler: Patch Set 3:
It will be mentioned in the contribution guide when CL 237257 is merged. Please don’t reply on this GitHub thread. Visit golang.org/cl/236999. |
…valuation Watch expressions are repeated over and over again while the program is running, pausing, continuing, etc, and the result is always displayed and continuously refreshed under WATCH. Unlike other types of evaluations (e.g. in REPL, where one expression is evaluated at a time, and the error can be buried among logging messages), there is no advantage to also showing the same error in a pop-up box. Fixes #143 Change-Id: I026955980d22e955e4af933bc68256dc320c3f56 GitHub-Last-Rev: 9a52492 GitHub-Pull-Request: #196 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236999 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
This PR is being closed because golang.org/cl/236999 has been merged. |
| this.sendErrorResponse(response, 2009, 'Unable to eval expression: "{e}"', { | ||
| e: err.toString() | ||
| }); | ||
| }, dest); |
There was a problem hiding this comment.
Is the default destination always user if nothing is passed here?
There was a problem hiding this comment.
Yes, the default is to show to the user, but I decided to spell out both options explicitly in the if-else, so it is clear what is going on.
Watch expressions are repeated over and over again while the program is running, pausing, continuing, etc, and the result is always displayed and continuously refreshed under WATCH. Unlike other types of evaluations (e.g. in REPL, where one expression is evaluated at a time, and the error can be buried among logging messages), there is no advantage to also showing the same error in a pop-up box.
Fixes #143