src/debugAdapter: adds error handling for remote connections #216
Conversation
googlebot
added
the
cla: yes
vjocw
changed the title
|
This PR (HEAD: 44d9b59) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/237559 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/237559. |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (2 comments) Thanks for finding the bug and offering the fix for it. Please don’t reply on this GitHub thread. Visit golang.org/cl/237559. |
|
@vincentjocodes Just in case the comment is not visible - the actual review happens in https://golang.org/cl/237559. Thanks again! |
vjocw
changed the title
|
Message from Vincent Jo: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/237559. |
json-rpc2 module doesn't catch all the errors in its callback. If a remote connection fails to be established, it won't call the callback for errors. So the connection will hang. There are no future plans to handle the error case through the callback: json-rpc2: pocesar/node-jsonrpc2#53. Node.js handles errors in a similar way: https://nodejs.org/api/net.html#net_socket_connect. Errors won't be exposed through the callback, only through the error listener. Fixes #215 Change-Id: I75cfb2a0cf6628a8c35ddccf8c96ec1ade0275f1 GitHub-Last-Rev: 44d9b59 GitHub-Pull-Request: #216 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237559 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
This PR is being closed because golang.org/cl/237559 has been merged. |
json-rpc2 module doesn't catch all the errors in its callback. If a remote connection fails to be established, it won't call the callback for errors. So the connection will hang. There are no future plans to handle the error case through the callback: json-rpc2: pocesar/node-jsonrpc2#53. Node.js handles errors in a similar way: https://nodejs.org/api/net.html#net_socket_connect. Errors won't be exposed through the callback, only through the error listener.
Fixes #215