-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply timeouts on child processes #91
Conversation
This PR (HEAD: c1bd71edd8945c50c000d64ffd9148fb54dd3e30) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/235121 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: d379386) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/235121 to see it. Tip: You can toggle comments from me using the |
I just created a bunch of merge conflicts for this PR - sorry! I will fix them and push them to the CL. Edit: Pushing to the CL directly probably wasn't the right move, but I got nervous to push directly to your branch. You can download my fixes by going to https://go-review.googlesource.com/c/vscode-go/+/235121 and clicking the "DOWNLOAD" button in the bottom right (or the "..." in the top right). |
Message from Rebecca Stambler: Patch Set 3: (2 comments) Thank you for contributing this change! I'm sorry about the merge conflict confusion (#91 (comment)), and please let me know if you have trouble getting the PR and this CL synced back up. I wish this change didn't have to touch so many different files, but I think that really means that we need a larger refactoring throughout the project, which is not in scope for this change. As such, I'm comfortable merging this, and I opened #104 so that we remember to work on a refactoring. Please don’t reply on this GitHub thread. Visit golang.org/cl/235121. |
Thanks for the PR. It seems like this is no longer a pressing issue after we migrated to a long running gopls sever instead of dozens of tools. Let's close this. |
Thanks @lggomez Thank you so much for all your continued support and contribution! |
Fixes microsoft/vscode-go#2348
For reference, all previous discussion can be seen on the original PR here: microsoft/vscode-go#2372