Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply timeouts on child processes #91

Closed
wants to merge 1 commit into from

Conversation

lggomez
Copy link
Contributor

@lggomez lggomez commented May 25, 2020

Fixes microsoft/vscode-go#2348

For reference, all previous discussion can be seen on the original PR here: microsoft/vscode-go#2372

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 25, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: c1bd71edd8945c50c000d64ffd9148fb54dd3e30) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/235121 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: d379386) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/235121 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@stamblerre
Copy link
Contributor

stamblerre commented May 27, 2020

I just created a bunch of merge conflicts for this PR - sorry! I will fix them and push them to the CL.

Edit: Pushing to the CL directly probably wasn't the right move, but I got nervous to push directly to your branch. You can download my fixes by going to https://go-review.googlesource.com/c/vscode-go/+/235121 and clicking the "DOWNLOAD" button in the bottom right (or the "..." in the top right).

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 3:

(2 comments)

Thank you for contributing this change! I'm sorry about the merge conflict confusion (#91 (comment)), and please let me know if you have trouble getting the PR and this CL synced back up.

I wish this change didn't have to touch so many different files, but I think that really means that we need a larger refactoring throughout the project, which is not in scope for this change. As such, I'm comfortable merging this, and I opened #104 so that we remember to work on a refactoring.


Please don’t reply on this GitHub thread. Visit golang.org/cl/235121.
After addressing review feedback, remember to publish your drafts!

@hyangah
Copy link
Contributor

hyangah commented Dec 29, 2021

Thanks for the PR. It seems like this is no longer a pressing issue after we migrated to a long running gopls sever instead of dozens of tools. Let's close this.

@hyangah
Copy link
Contributor

hyangah commented Jul 6, 2022

Thanks @lggomez
Since we've migrated to gopls that unifies many tools, we rarely encounter issues related to the problem this PR was aiming to tackle. Now the code base was changed a lot, and many of those tools are now legacy that are meant to be removed. So, I will close this PR.

Thank you so much for all your continued support and contribution!

@hyangah hyangah closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeouts for every process (except the ones that run in server mode) spawned by the extension
5 participants