Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in helm.sh/helm/v3: GHSA-c38g-469g-cmgx #1040

Closed
GoVulnBot opened this issue Oct 5, 2022 · 3 comments
Closed
Assignees

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-c38g-469g-cmgx, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
helm.sh/helm/v3 3.5.1 >= 3.0, < 3.5.1

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: TODO
    versions:
      - introduced: 3.0.0
        fixed: 3.5.1
    packages:
      - package: helm.sh/helm/v3
description: |4-

    Since Helm 2 was released, a well-documented aspect of Helm is that the Helm chart's version number MUST follow the SemVer2 specification. In the past, Helm would not permit charts with malformed versions. At some point, a patch was merged that changed this - On a version parse error, the version number was simply passed along as-is. This provided a vector for malicious data to be injected into Helm and potentially used in various ways.

    Core maintainers were able to send deceptive information to a terminal screen running the `helm` command, as well as obscure or alter information on the screen. In some cases, we could send codes that terminals used to execute higher-order logic, like clearing a terminal screen.

    Further, during evaluation, the Helm maintainers discovered a few other fields that were not properly sanitized when read out of repository index files. This fix remedies all such cases, and once again enforces SemVer2 policies on version fields.

    All users of the Helm 3 should upgrade.

    Those who use Helm as a library should verify that they either sanitize this data on their own, or use the proper Helm API calls to sanitize the data.

    ### Patches
    This issue has been resolved in Helm 3.5.1.

    While this fix does not constitute a breaking change, as all field formatting is now enforced as documented, it is possible that charts that were mistakenly allowed (but invalid) may no longer be available in search indexes. Specifically, **malformed SemVer versions are no longer supported**. This has always been the documented case, but it is true that malformed versions were allowed.

    Note that this is the first security release since Helm 2's final deprecation. Helm 2 was not audited for vulnerability to this issue, and should be assumed vulnerable.
cves:
  - CVE-2021-21303
ghsas:
  - GHSA-c38g-469g-cmgx

@tatianab
Copy link
Contributor

tatianab commented Oct 5, 2022

This was classified as NOT_IMPORTABLE in #819 but we are taking another look

@tatianab tatianab assigned neild and unassigned tatianab Oct 11, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/443458 mentions this issue: data/reports: add GO-2022-1040.yaml for CVE-2021-21303

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/451282 mentions this issue: data/excluded: delete GO-2022-0819, dupe of GO-2022-1040

gopherbot pushed a commit that referenced this issue Nov 18, 2022
For #819, #1040

Change-Id: I1af911998bfc0bdc413d12f363fccb6b2fe078e8
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/451282
Run-TryBot: Tatiana Bradley <tatiana@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants