Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/sigstore/rekor: GHSA-2h5h-59f5-c5x9 #1754

Closed
GoVulnBot opened this issue May 3, 2023 · 3 comments
Assignees
Labels
excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-2h5h-59f5-c5x9, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/sigstore/rekor 1.1.1 < 1.1.1

Cross references:
No existing reports found with this module or alias.

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: github.com/sigstore/rekor
    versions:
      - fixed: 1.1.1
    packages:
      - package: github.com/sigstore/rekor
summary: Rekor's compressed archives can result in OOM conditions
description: |-
    ## Summary
    Two vulnerabilities have been found in Rekor types for archive files JARs and APKs, where Rekor would crash due to out of memory conditions caused by reading archive metadata files into memory without checking their sizes first causing a Denial of Service of Rekor.

    These vulnerabilities were found through fuzzing with [OSS-Fuzz](https://google.github.io/oss-fuzz/).

    ## Vulnerability 1: OOM due to large files in META-INF directory of JAR files.
    ### Summary
    Verification of a JAR file submitted to Rekor can cause an out of memory crash if files within the META-INF directory of the JAR are sufficiently large.

    ### Details
    As part of verifying a JAR file, Rekor uses the [relic library](http://github.com/sassoftware/relic) to check that the JAR is signed, the signature verifies, and that the hashes in the signed manifest are all valid. This library function reads files within META-INF/ into memory without checking their sizes, resulting in an OOM if the uncompressed file is sufficiently large. Rekor is also not performing any such checks prior to passing the JAR to this library function.

    ### Patches
    Users should update to the latest version of Rekor, 1.1.1.

    ### Workaround
    There are no workarounds, users should update.

    ## Vulnerability 2: OOM due to large .SIGN and .PKGINFO files in APK files.
    ### Summary
    Parsing of an APK file submitted to Rekor can cause an out of memory crash if the .SIGN or .PKGINFO files within the APK are sufficiently large.

    ### Details
    When parsing an APK file, Rekor allocates byte slices to read both the .SIGN and .PKGINFO files into memory in order to verify the signature and hashes in the APK. These byte slices are allocated based on the size included in the tar header for each file, with no checks performed on that size. If the size in the header is sufficiently large, either because the uncompressed file is large or the size in the header has been artificially set to a large value, Rekor will crash due to an out of memory panic.

    ### Patches
    Users should update to the latest version of Rekor, 1.1.1.

    ### Workaround
    There are no workarounds, users should update.
cves:
  - CVE-2023-30551
ghsas:
  - GHSA-2h5h-59f5-c5x9
references:
  - advisory: https://github.com/sigstore/rekor/security/advisories/GHSA-2h5h-59f5-c5x9
  - fix: https://github.com/sigstore/rekor/commit/cf42ace82667025fe128f7a50cf6b4cdff51cc48
  - web: https://github.com/sigstore/rekor/releases/tag/v1.1.1
  - advisory: https://github.com/advisories/GHSA-2h5h-59f5-c5x9

@jba jba self-assigned this May 9, 2023
@jba jba added the excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable. label May 9, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/493895 mentions this issue: data/excluded: batch add GO-2023-1763, GO-2023-1764, GO-2023-1761, GO-2023-1758, GO-2023-1754

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592760 mentions this issue: data/reports: unexclude 75 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/606785 mentions this issue: data/reports: unexclude 20 reports (5)

gopherbot pushed a commit that referenced this issue Aug 20, 2024
  - data/reports/GO-2023-1700.yaml
  - data/reports/GO-2023-1701.yaml
  - data/reports/GO-2023-1707.yaml
  - data/reports/GO-2023-1708.yaml
  - data/reports/GO-2023-1716.yaml
  - data/reports/GO-2023-1718.yaml
  - data/reports/GO-2023-1719.yaml
  - data/reports/GO-2023-1721.yaml
  - data/reports/GO-2023-1723.yaml
  - data/reports/GO-2023-1730.yaml
  - data/reports/GO-2023-1735.yaml
  - data/reports/GO-2023-1738.yaml
  - data/reports/GO-2023-1747.yaml
  - data/reports/GO-2023-1754.yaml
  - data/reports/GO-2023-1758.yaml
  - data/reports/GO-2023-1761.yaml
  - data/reports/GO-2023-1763.yaml
  - data/reports/GO-2023-1764.yaml
  - data/reports/GO-2023-1768.yaml
  - data/reports/GO-2023-1774.yaml

Updates #1700
Updates #1701
Updates #1707
Updates #1708
Updates #1716
Updates #1718
Updates #1719
Updates #1721
Updates #1723
Updates #1730
Updates #1735
Updates #1738
Updates #1747
Updates #1754
Updates #1758
Updates #1761
Updates #1763
Updates #1764
Updates #1768
Updates #1774

Change-Id: I3fc567427d68e095cc62ea48dc9b284b2414a372
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/606785
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable.
Projects
None yet
Development

No branches or pull requests

3 participants