-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support install-mode: none #1049
Comments
go1.23 support is currently available at |
I wonder if the fact of looking for the binary inside the PATH should be a hard restriction or if the action should allow to define a path to a binary. |
@jlevesy what is exactly the problem with the current installation of golangci-lint binary? |
No.
Yes. I'm looking into the possibility of using something else (devbox) to install golangci-lint in the workflow.
No.
With the following {
"packages": [
"go@1.22",
"golangci-lint@1.59"
]
} Then I can have the following CI workflow defined with the described behavior: name: CI
on: [pull_request]
jobs:
ci:
name: CI
runs-on: ubuntu-22.04
steps:
- name: Checks out the code
uses: actions/checkout@v3
- name: Install devbox
uses: jetify-com/devbox-install-action@v0.10.0 # <- installs go and golangci-lint, makes them available into the path
- name: Run Linter
uses: golangci/golangci-lint-action@v6 # <- runs golangci-lint, using the version available from the path.
with:
install-mode: none |
Maybe we can use |
Thanks a lot! |
Welcome
Your feature request related to a problem? Please describe.
Hey,
I'm exploring the idea of using a project level package manager (https://www.jetify.com/devbox/) for our tooling and we would like for it to handle the installation of golangci-lint in our CI.
That being said, the action offers some nice caching capabilities and feedback features that we would still be happy to keep using.
But we can't really do that with the current golangci-lint apparently,
Describe the solution you'd like.
Would it make sense to add a third value (
None
) to the install mode enum, that would only lookup in the system where golangci-lint is being installed?Describe alternatives you've considered.
Not using the golangci-lint action :(.
Additional context.
No response
The text was updated successfully, but these errors were encountered: