Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add install-mode none #1070

Closed
wants to merge 1 commit into from
Closed

Conversation

Zxilly
Copy link

@Zxilly Zxilly commented Jul 2, 2024

Fixes #1049

go1.23 support is currently available at https://github.com/ldez/golangci-lint/tree/feat/go1.23, but due to limitations of goinstall, it must be manually git cloned and then go install. Adding the none installation option allows users to perform this step themselves and still benefit from the cache mechanism provided by this action.

@ldez ldez self-requested a review July 2, 2024 15:41
@ldez ldez added blocked Need's direct action from maintainer labels Jul 2, 2024
@ldez
Copy link
Member

ldez commented Jul 2, 2024

Another possibility is to wait more than a few hours for an answer to your initial question about my PR, before trying to address an issue labeled as a proposal.
proposal means "need to be discussed".

@Zxilly
Copy link
Author

Zxilly commented Jul 3, 2024

I'm sorry, could you explain it more clearly please? What should I do now? Wait for the proposal to get an explicit response?

@ldez ldez added enhancement New feature or request declined and removed blocked Need's direct action from maintainer enhancement New feature or request labels Jul 29, 2024
@ldez
Copy link
Member

ldez commented Jul 29, 2024

The PR has the same problem as the previous one #1069 (comment)

@ldez ldez closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support install-mode: none
2 participants