-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caches: Do we really need them anymore? The current implementation conflicts with automatic caching in latest setup-go
.
#863
Comments
setup-go
.
On second thought. The combination of telling |
I believe the cache does not simply contain Go's build artifacts: it also caches the analyzer facts / reporting for each package and reuses cached outputs when the dependency closure for a package doesn't change. It might warrant creating an option to skip the go build cache specifically though. |
Yes, or even potentially just writing to a path that won't conflict. You could even provide an option to summarise the |
* chore: cleanup local golangci * remove different golangci-config * add merge group step to push step * upgrade golangci to 1.56 * update golangci action * try skip cache golangci/golangci-lint-action#863 * try single golangci-lint * don't set only new issues in config * Update checks.yaml Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com> * log context * point to commit * only new issues on pr or merge group --------- Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com>
* chore: cleanup local golangci * remove different golangci-config * add merge group step to push step * upgrade golangci to 1.56 * update golangci action * try skip cache golangci/golangci-lint-action#863 * try single golangci-lint * don't set only new issues in config * Update checks.yaml Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com> * log context * point to commit * only new issues on pr or merge group --------- Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com>
* chore: cleanup local golangci * remove different golangci-config * add merge group step to push step * upgrade golangci to 1.56 * update golangci action * try skip cache golangci/golangci-lint-action#863 * try single golangci-lint * don't set only new issues in config * Update checks.yaml Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com> * log context * point to commit * only new issues on pr or merge group --------- Co-authored-by: Dave Mihalcik <dmihalcik@virtru.com>
Welcome
Your feature request related to a problem? Please describe.
The
actions/setup-go
action which is a requirement of this action already, has automatic caching now. When using that feature withskip-pkg-cache: false
it causes many annotations to appear like the following screenshot.Describe the solution you'd like.
Would it be possible to just have this action store it's caches in the same directories the
actions/setup-go
action uses? Then things should just work out of the box I assume.Describe alternatives you've considered.
Setting
skip-pkg-cache: true
when using the latestsetup-go
actions.Additional context.
Not much. But happy to provide.
The text was updated successfully, but these errors were encountered: