Can the release of version node20 be considered?

[178inaba]

Welcome

• Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
• Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

I have received the following warning.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Describe the solution you'd like.

I would like a version released using node20 to address the warning.

Describe alternatives you've considered.

None.

Additional context.

v3.7.0 (latest version): node16

golangci-lint-action/action.yml

Line 45 in 3a91952

using: "node16"

master: node20

golangci-lint-action/action.yml

Line 45 in e38f944

using: "node20"

[azisaka]

while we don't get a new version you can replace uses: golangci/golangci-lint-action@v3 by uses: golangci/golangci-lint-action@master

[178inaba]

@azisaka
Thank you for the reply! I also considered that approach, but it seems that specifying branches is not recommended in the Actions documentation.

Using the default branch of an action may be convenient, but if someone releases a new major version with a breaking change, your workflow could break.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses

Under this release management approach, users should not be referencing an action's default branch, as it's likely to contain the latest code and consequently might be unstable. Instead, you can recommend that your users specify a major version when using your action, and only direct them to a more specific version if they encounter issues.
https://docs.github.com/en/actions/creating-actions/about-custom-actions#good-practices-for-release-management

[rhussmann]

@178inaba one more workaround that doesn't depend on a moving ref

uses: golangci/golangci-lint-action@c67416616c29c3c48d26b59c45cadb56966d80aa

where c67416616c29c3c48d26b59c45cadb56966d80aa is the full commit SHA where action.yml was updated to point to node20.

Still looking forward to seeing a persistent tag published with this support as I'd prefer not to have to rely on a specific commit.

[ldez]

Hello,

I will create a new release in a few minutes.

[ldez]

Done https://github.com/golangci/golangci-lint-action/tags
v3 updated and v3.7.1 created.

[178inaba]

@ldez Thanks!

[lukestoward]

@ldez ideally this change should have been a new major version aligning with how other standard actions managed the upgrade. See actions/cache, actions/setup-go etc.

This has broken our pipeline as a result, as Node 20 requires newer GLIBC versions. Easily fixed, but we will have to pin the version to v3.7.0 now instead of using @v3.

[ldez]

Sorry, I will create a v4 and try to restore the previous v3.

[ldez]

I moved the tag v3 to v3.7.0 and created v4 and v4.0.0

I'll keep v3.7.1 to avoid being too breaking.

[lukestoward]

Great, thanks for the quick resolution!