Add instructions for multi-os linting #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a matrix to show how to do multi-os lint builds. This is specifically needed if you have files like `_darwin.go` or `_windows.go`, etc. If you don't lint on that specific OS, then those files will NOT be linted. I also added a note about `.gitattributes` needing to have the line endings correctly checked out, otherwise linting will fail for formatting as well.
SVilgelm
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Please also update the version of lint action in main example: https://github.com/golangci/golangci-lint-action/pull/86/files#diff-04c6e90faac2675aa89e2176d2eec7d8R36
to v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a matrix to show how to do multi-os lint builds. This is specifically needed if you have files like
_darwin.goor_windows.go, etc. If you don't lint on that specific OS, then those files will NOT be linted.I also added a note about
.gitattributesneeding to have the line endings correctly checked out, otherwise linting will fail for formatting as well.