Skip to content

Commit

Permalink
golint: deprecation (#1965)
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez authored May 10, 2021
1 parent ce67262 commit f95b1ed
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
3 changes: 0 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ linters-settings:
min-complexity: 15
goimports:
local-prefixes: github.com/golangci/golangci-lint
golint:
min-confidence: 0
gomnd:
settings:
mnd:
Expand Down Expand Up @@ -82,7 +80,6 @@ linters:
- gocyclo
- gofmt
- goimports
- golint
- gomnd
- goprintffuncname
- gosec
Expand Down
3 changes: 2 additions & 1 deletion pkg/lint/lintersdb/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
WithSince("v1.0.0").
WithLoadForGoAnalysis().
WithPresets(linter.PresetStyle).
WithURL("https://github.com/golang/lint"),
WithURL("https://github.com/golang/lint").
Deprecated("The repository of the linter has been archived by the owner.", "v1.41.0", "revive"),
linter.NewConfig(golinters.NewRowsErrCheck()).
WithSince("v1.23.0").
WithLoadForGoAnalysis().
Expand Down
2 changes: 1 addition & 1 deletion test/run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func TestTimeoutInConfig(t *testing.T) {

func TestTestsAreLintedByDefault(t *testing.T) {
testshared.NewLintRunner(t).Run(getTestDataDir("withtests")).
ExpectHasIssue("`if` block ends with a `return`")
ExpectHasIssue("don't use `init` function")
}

func TestCgoOk(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/default_exclude.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//args: -Estylecheck,golint
//args: -Estylecheck,golint --internal-cmd-test
//config_path: testdata/configs/default_exclude.yml

/*Package testdata ...*/
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/golint.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//args: -Egolint
//args: -Egolint --internal-cmd-test
package testdata

var Go_lint string // ERROR "don't use underscores in Go names; var `Go_lint` should be `GoLint`"
Expand Down

0 comments on commit f95b1ed

Please sign in to comment.