Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errname linter #2129

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Add errname linter #2129

merged 5 commits into from
Aug 4, 2021

Conversation

Antonboom
Copy link
Contributor

@Antonboom Antonboom commented Jul 22, 2021 •
edited
Loading

Hello!

https://github.com/Antonboom/errname

I'm sorry, I am confused about goanalysis.LoadMode and linter.Preset*. I don't see any documentation that explains which constants are best for your linter.

Thank u for any suggestions.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 22, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez ldez added the linter: new Support new linter label Jul 22, 2021
@ldez ldez self-requested a review July 22, 2021 09:33
@Antonboom
Copy link
Contributor Author

Antonboom commented Jul 22, 2021 •
edited
Loading

@ldez, also, I am not a native english speaker.

Maybe u can suggest more pleasant form for error message than

the sentinel error `EndOfFileError` should be of the form ErrXxx
the error type `someTypeWithoutPtr` should be of the form xxxError

?

(especially interested in articles)

@ldez
Copy link
Member

ldez commented Jul 25, 2021

Hello @Antonboom, could you sign the CLA?

@ldez ldez added the feedback required Requires additional feedback label Jul 25, 2021
@Antonboom
Copy link
Contributor Author

@ldez, done

@Antonboom
Copy link
Contributor Author

@ldez, something else?

@ldez
Copy link
Member

ldez commented Jul 31, 2021

Sorry, it's always the same thing: a day has only 24h 😸
I will spend some time on your PR this weekend.

@ldez
Copy link
Member

ldez commented Aug 3, 2021

@Antonboom take a look to Antonboom/errname#2

@Antonboom
Copy link
Contributor Author

@ldez, thanks!

Merged. This MR updated too

@ldez ldez removed the feedback required Requires additional feedback label Aug 3, 2021
ldez
ldez approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SVilgelm SVilgelm merged commit 652bd91 into golangci:master Aug 4, 2021
@golangci-automator
Copy link

Hey, @Antonboom — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@Antonboom @SeigeC
Add errname linter (golangci#2129)
8331c97 
* Add errname linter

* bump errname version
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@SVilgelm SVilgelm SVilgelm approved these changes

Assignees
No one assigned
Labels
linter: new Support new linter
Projects
None yet
Milestone
v1.42
Development

Successfully merging this pull request may close these issues.
4 participants
@Antonboom @CLAassistant @ldez @SVilgelm