Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nilassign linter #2131

Merged
merged 2 commits into from
Jul 28, 2021
Merged

add nilassign linter #2131

merged 2 commits into from
Jul 28, 2021

Conversation

sivchari
Copy link
Member

@sivchari sivchari commented Jul 24, 2021 •
edited by ldez
Loading

nilassign finds that assigning to invalid memory address or nil pointer dereference.
https://github.com/sivchari/nilassign

@ldez ldez added the linter: new Support new linter label Jul 24, 2021
@ldez ldez self-requested a review July 24, 2021 18:56
@ldez ldez added the feedback required Requires additional feedback label Jul 25, 2021
@ldez ldez removed the feedback required Requires additional feedback label Jul 25, 2021
@sivchari
Copy link
Member Author

@ldez
hi, thanks for the review and the fix!
what should I do after this?

@ldez ldez merged commit bbf0450 into golangci:master Jul 28, 2021
@golangci-automator
Copy link

Hey, @sivchari — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@sivchari sivchari deleted the add-nilassign-linter branch July 29, 2021 02:26
@ldez
Copy link
Member

ldez commented Aug 3, 2021

After more investigation on this linter, there are too many false positives.
I will revert this PR (as it's not a part of the release), please submit a new PR when your linter will be more reliable.

ldez added a commit to ldez/golangci-lint that referenced this pull request Aug 3, 2021
@ldez
Revert "add nilassign linter (golangci#2131)"
5308fb2 
This reverts commit bbf0450.
@ldez ldez mentioned this pull request Aug 3, 2021
Merged
@sivchari
Copy link
Member Author

sivchari commented Aug 3, 2021

@ldez
Hi, thanks for review and submit issue.
I'll refer to it and make it more reliable. After I've fixed it, I'd push new PR.

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@sivchari @ldez @SeigeC
add nilassign linter (golangci#2131)
54767db 
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
linter: new Support new linter
Projects
None yet
Milestone
v1.42
Development

Successfully merging this pull request may close these issues.
2 participants
@sivchari @ldez