Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/GaijinEntertainment/go-exhaustruct/v3 from 2.3.0 to 3.1.0 #3963

Merged
merged 1 commit into from
Jul 21, 2023
Merged

build(deps): bump github.com/GaijinEntertainment/go-exhaustruct/v3 from 2.3.0 to 3.1.0 #3963

merged 1 commit into from
Jul 21, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 20, 2023 •
edited
Loading

Bumps github.com/GaijinEntertainment/go-exhaustruct/v3 from 2.3.0 to 3.1.0.

GaijinEntertainment/go-exhaustruct@v2.3.0...v3.1.0

https://github.com/GaijinEntertainment/go-exhaustruct/releases/tag/v3.0.0

Fixes #3960

This update is done by hand because dependabot is not able to update a major version of a dependency.

@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code breaking labels Jul 20, 2023
bombsimon
bombsimon approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's remember to add a note in the next release notes that users may have to change their regex due to the breaking change in v3.

@ldez ldez merged commit d58342f into golangci:master Jul 21, 2023
14 checks passed
@ldez ldez deleted the bump-exhaustruct branch July 21, 2023 11:31
@orestisfl
Copy link

LGTM!

Let's remember to add a note in the next release notes that users may have to change their regex due to the breaking change in v3.

@bombsimon I don't see this in the latest release notes. For reference, the breaking changes for exhaustruct: https://github.com/GaijinEntertainment/go-exhaustruct/releases/tag/v3.0.0

@ldez
Copy link
Member Author

ldez commented Aug 10, 2023 •
edited
Loading

I will add a note in the next release.

Edit: https://golangci-lint.run/product/roadmap/#v1540

@Nivl
Copy link
Member

Nivl commented Aug 11, 2023 •
edited by ldez
Loading

For reference this used to work before:

  • 'sql\.NullString$', now it needs to be 'database/sql\.NullString$'.
  • For 3rd party packages you need to use the full package name like 'github.com/google/uuid\.NullUUID$' instead of 'uuid\.NullUUID$'

@ldez ldez added this to the v1.54 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
breaking dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.54
Development

Successfully merging this pull request may close these issues.

Support exhaustruct v3
4 participants
@ldez @orestisfl @Nivl @bombsimon