-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: temporarily hide warning about using plugins using the old API #4002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your comment (which I also wrote in the ticket). I don't get how waiting until the next release to display the log message would make any difference? It will just give the user less time to fix, or golangci-lint
one extra release before fully deprecating/removing (if ever?).
b8fa47f
to
105da96
Compare
I updated to PR based on #4001 (comment) @bombsimon WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments
Co-authored-by: Simon Sawert <simon@sawert.se>
Fixes #4001
I will create a PR after the merge of this one to restore the log.