Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve govet description #4366

Merged
merged 3 commits into from
Feb 15, 2024
Merged

docs: improve govet description #4366

merged 3 commits into from
Feb 15, 2024

Conversation

silverwind
Copy link
Contributor

As per #4363 (comment), I think it's good to clarify this. Aim is to get this on the docs page. I did not add a . at the end of the sentence as it seems the docs build does that.

Copy link

boring-cyborg bot commented Feb 9, 2024

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2024

CLA assistant check
All committers have signed the CLA.

pkg/golinters/govet.go Outdated Show resolved Hide resolved
@ldez ldez changed the title docs: Clarify govet description docs: improve govet description Feb 9, 2024
@ldez ldez added enhancement New feature or improvement area: docs labels Feb 9, 2024
@silverwind
Copy link
Contributor Author

silverwind commented Feb 9, 2024

As per #4363 (comment), I think I will change it to this, highlighting the fact that they are not exactly the same (for example when go vet adds new passes but golangci has not updated yet):

It is roughly the same as 'go vet' and uses its passes.

pkg/golinters/govet.go Outdated Show resolved Hide resolved
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit cc78204 into golangci:master Feb 15, 2024
12 checks passed
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the next milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants