Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nolintlint: remove empty line in unused directive replacement #4973

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Sep 3, 2024

When using the nolintlint linter in autofix mode, it does not remove the empty line along with the unused linter directive if it starts from a new line. Expected behavior: should remove the empty line.

Copy link

boring-cyborg bot commented Sep 3, 2024

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented Sep 3, 2024

Hello, can you add a description to your PR?

@ldez ldez changed the title fix(nolintlint): remove empty line in unused directive replacement nolintlint: remove empty line in unused directive replacement Sep 3, 2024
@ldez ldez added the feedback required Requires additional feedback label Sep 4, 2024
@ldez ldez self-requested a review September 4, 2024 02:40
@ldez ldez added linter: update Update the linter implementation inside golangci-lint area: auto-fix labels Sep 4, 2024
@reugn
Copy link
Contributor Author

reugn commented Sep 4, 2024

Hi @ldez, I've added a description to the pull request.

@ldez ldez removed the feedback required Requires additional feedback label Sep 4, 2024
@ldez ldez added this to the next milestone Sep 4, 2024
@ldez ldez added the bug Something isn't working label Sep 4, 2024
@ldez ldez force-pushed the nolintlint-remove-empty-line branch from 07ded93 to f1d1bb5 Compare September 4, 2024 11:55
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 3797ed9 into golangci:master Sep 4, 2024
16 checks passed
@reugn reugn deleted the nolintlint-remove-empty-line branch September 4, 2024 12:20
@ldez ldez modified the milestones: next, v1.61 Sep 9, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: auto-fix bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants