fix: enable paths with junction inside windows #5245
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
blaubaer
force-pushed
the
windows-junctions
branch
from
66e364d to
440ee75
Compare
|
@ldez I really tried to add tests at first. Because of the required complexity of the system requirements, like having a junction that needs to be created by the test itself and so, I tried to make the impact as simple as possible instead and tested it on my own machine instead. |
blaubaer
force-pushed
the
windows-junctions
branch
from
440ee75 to
b857efd
Compare
ldez
added
feedback required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the behavior of
filepath.EvalSymlinkswhich errors withsyscall.ENOTDIRif the provided path does include a Junction on Windows. Junctions can happen if a volume is mounted inside another drive as a subdirectory, for example. This can be usually happen if used with the feature Dev Drives and this replaces existing directories.See original issue golang/go#40180. This issue is currently unresolved, and the ticket is leaning towards leaving this to the interpretation of the evaluating code rather than handling it within
filepath.EvalSymlinksitself.As
syscall.ENOTDIRis only returned when callingfilepath.EvalSymlinkson Windows if a part of the presented path is a Junction and nothing before was a symlink, we simply treat this as NOT symlink, because a symlink above the Junction does not make sense at all.