-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish translation (buena suerte) #95
Comments
@eduardomontalvo no rush, just checking whether everything is clear and if I assist in anyway? |
Greetings. I met a guy in another project who's doing Spanish translation, he's just not technical/Node-developer. He's willing to translate all the sections (inner pages) so you're left to: (1) translate only the home page - which I noted you already did most of it (2) verify his work. Are you available these days for this? |
Hi @i0natan, I was just checking again this project since its advices are being useful to me for my current project. I just noticed it's still not fully translated to my mother language, but I see that you already have plans for it. Let me know if I may help in any way. |
@desko27 Welcome aboard :] Is your mother tongue language Spanish? If yes, we will really appreciate some help - Already have the home page 70% translated and a guy who can translate all inner page. Just need someone who can coordinate this work. |
@i0natan Thanks! Yes it is, I'm from Barcelona, Spain. Wow 70% translated at the home page, that's good news! So what do you mean by coordinating this work? Are you talking about setting some conventions/standards? By the other hand, I'll be happy to collaborate by reviewing the translations if that's helpful. Would that be ok? |
Hey @desko27, Barcelona is good! :) Coordinate = you lead the Spanish translation the way you like. You have 2 resources that you might or not use: (1) this PR translated part of the home page, it's around 50-80% completed (2) there is a guy who's willing to translate all inner-pages in few days, but he's not technical so probably have to go through this and ensure that the translation is appropriate What do you think? The Spanish PR: https://github.com/i0natan/nodebestpractices/pull/16/files |
@i0natan I see! I'll keep an eye on that PR then. Thanks! |
@desko27 So you wanna take the Spanish translation and handle it? should I connect you with the guy who can translate all the inner pages (then you just need to go over it and approve)? Your name of course will appear on top of the Spanish page + on the English repo main page |
@i0natan Yeah, that would be fantastic, my skype/discord ID is desko27. |
@desko27 Great! The guy will be available starting from Tuesday next week, I'll make sure to schedule a mutual session. He can carry the heavy lifting, make the first translation, and you as a developer can ensure that the technical lingo isn't lost in translation |
@desko27 Cool, pinging on skype tomorrow |
@desko27 Added on Skype |
@desko27 Added to the Spanish branch the partial homepage translation that was previously done + a Spanish file for each inner page (e.g. sections/errorhandling/asyncerrorhandling.spanish.md) so you can paste the translation. Can I help in any other way? https://github.com/i0natan/nodebestpractices/tree/spanish-translation |
@i0natan Hi, I took a look today and saw that the guy who is translating the inner pages translated a few of them. I have some personal issues to attend to this week. Next week on monday/tuesday I'll be updating this with the existing translations, and I may translate some of the remaining translations in the homepage. Just a detail, this spanish inner page was not copied from english but chinese. |
@desko27 Cool, you're the captain, do it on your convenient time and take the ship to Costa Brava. Just if possible, Seth has asked few questions in the Excel, can you answer him as he wishes to accomplish his work? Sorry about the inner page issue, I guess it's only 1 and the rest are good |
@desko27 Just a minor question - do we need anything else from Seth? did he did his job? |
Hey @i0natan !! I only see around 25% of translations done in our shared document. Should I wait for Seth to complete his work or should I review & PR the existing translations? By the other hand, last changes were made by Seth 20 days ago. We maybe should ask him if everything is ok? |
@desko27 Let's approach him in Skype and ask about this... I was sure that we was done with the work |
@desko27 I managed to catch Seth, it wasn't easy, he said that we disappeared... :] Practically, he's willing now to finalize but have one concern: "As a note, in the excel it shows 46 articles or so but the links are 30 something, do you have the other links so we can translate those articles too? " Let me know what should I answer? |
@i0natan that's cool! About the links, I'll check it when I get home. Some articles had no one-paragraph explanation, so it's probably that. |
@desko27 Thanks for the vast answer, let's make him finalize this quick. Maybe you can add more articles from the security branch which will get PRed soon (6.1-6.22): |
@desko27 I had hard time to get his attention, any chance we just push the links pasting so he can finalize his work? |
@i0natan this is the report:
So I can paste new links soon, but there's at least 2/3 of pending work already which doesn't depend on us. In other words, we're not blocking him in any way. Also, as a reminder, the current links are the only ones that had a one-paragraph explanation, that's why there's only 34. |
You're absolutely right in every word. He just wants to perform all in one shot, so he gets all the links and get down on it. He doesn't want to perform few iterations, so the "blocking" artifacts are the rest of the links. @desko27 |
@i0natan Ok, I understand. I'll be home in 2-3h from now, so I'll ensure to provide the new links from the security branch by then. With that done he can perform the one shot 👍 |
@i0natan All new links from the security branch are now inserted into the document. There's a total of 51 links. I'll be watching for any question he may have. |
Hey guys, I'm finishing off #363 on August, I can finally have some schedule for it... stay tuned. |
Sounds great! |
@goldbergyoni @js-kyle, about #363, I already completed all "one paragraph explainers" for sections from 1 to 5 👌 I would like to start section 6 (Security Best Practices), but since it was included to |
Hey @desko27 Awesome! Regarding getting started on Section 6, I think it might be best to merge the current branch to master, then create a fresh start for part 6? Whichever option makes it easier for you. If you have a preference, let us know here and we can arrange that |
@js-kyle that's cool! so this is the roadmap, in this specific order:
|
Hey @desko27, I think this is ready to continue work on a new branch now. Please let me know if the merge with master is what you were expecting, otherwise, I can fix it! |
@js-kyle I see, that's perfect 😄 I'm busy for the next two weeks. So after that, I'm working on a new PR ✍️ for section 6 🔒 Security Best Practices. |
Hey so.. i was looking for some projects to start contributing and this one looks beginner friendly, |
@ZyBax that's awesome, welcome! Were you interested in helping with the Spanish translation? |
@js-kyle yeah i have seen some issues already, also im getting into node and this looks like a great source on info i'll make sure to read it all |
The current working branch for spanish is https://github.com/goldbergyoni/nodebestpractices/tree/spanish-translation So you can create a fork of this repository for you to work on, then once you have some progress, we will be happy to review it. @desko27 is leading the Spanish translation, and has currently worked through sections 1 - 5, and will work on section 6 soon I believe. Perhaps you could work on some items for section 6, and he could review it once ready |
Hi! Any pending translations? |
Hi @ZyBax @Anonyma! I'm sorry, I've been a little bit busy. I'll try to expose the current status of the translation project so you can decide what's the best way for you to contribute: One paragraph explainersThere's no much left to do with these ones. Anything is improvable by the community though.
Main readme file [link]There's still work to be done and help is appreciated.
Also, the english contents present in spanish main file are a bit outdated, so translations should be done by looking at the updated english main file instead. We could also "update" the spanish main file with the latest english text before going any further. |
@desko27 Awesome summary. Whenever you feed the Spanish translation is good enough to be published - let us know. I don't think it should be perfect, we're a community-based project so even if it's 85% ready - let spread the word @ZyBax @Anonyma Welcome abroad, we will be glad to have you hear on improving the content! 🎉 |
I already translated until point 7.2 . I'm spanish native |
That's awesome @Whitefox98 👏 👏 I've been struggling to get some time for this and I was expecting to use holidays. I'll help with the review ASAP! Thank you! |
No problem, Thanks to you to help the comunity! @desko27 |
Hello there! 👋 |
Hi @goldbergyoni, are you still working on this? I saw that the home is 100% translated, but not the inner pages. I'm spanish native and I could give some help. |
@jormaechea I've been translating the project myself in the past but I have no time to keep doing it right now, so any contribution is appreciated. I'm just helping with reviews, so feel free to identify what's missing, send a PR and I'll take a look in order for it to be merged ASAP 👍🏻 Thank you so much. |
Great @desko27, I’ll try to spend some time on this. Can we reopen the issue? |
Hello @jormaechea, welcome to node best practices and thanks for offering to contribute 😀 |
Suggestion: switch to fast-check in examples for property based
https://github.com/i0natan/nodebestpractices/blob/spanish-translation/README.md
@eduardomontalvo - Spanish translation can be officially kicked-off. You're the lead! I'll be at your disposal should you need anything. A branch was created (link below), you should have permissions to it, everyone else must PR before changing anything there.
I would ask/recommend only 2 important guidelines:
Keep the same content & formatting - the focus is on translation, should anyone want to modify the content or the graphics - let's PR first in English and them translate to Spanish
Duplicate pages - the content should be translated over a page duplication. Readme.MD became Readme.spanish.MD, all other files should be duplicated similarly. So the number of English & Spanish pages should be the same. Will create a bold link from the English home page to the Spanish home page (with bold credit of course...)
https://github.com/i0natan/nodebestpractices/blob/spanish-translation/README.md
The text was updated successfully, but these errors were encountered: