-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettier to Code Style Practices #85
Conversation
@septa97 thanks for joining the battle :) I'd like to clarify that a bit - why prefer prettier over eslint fixes? they at least overlap, no? should we mention vendors like this or maybe focus on the need and the less explicitly at the bottom specify few vendors? |
Prettier is made specifically to format code unlike ESLint that format codes and at the same time, it checks for possible code errors (linting). My practice in my projects is to use Prettier to format the code and to use ESLint to check for errors. Here is the link of an instance where Prettier performs better than ESLint in code formatting. And yes, Prettier and ESLint overlaps in the code formatting feature but it can be easily solved by using other packages like prettier-eslint, eslint-plugin-prettier, and eslint-config-prettier. For more information about their difference, you can view the link here. |
Those 3 packages that I mentioned are for Prettier and ESLint integration. |
Just a question, do you think I should just include this in section 3.1 together with ESLint? Since they are meant to be used together. |
@septa97 sorry for the late reply, somehow missed this useful thread. I think the case for prettier is clear and valuable, I would include it as part of ESLint:
cool? thanks! |
Done changing the PR. I'll kindly wait for your review and comments. |
@septa97 I merged the PR, great contribution. Had to perform two changes because both are not aligned with our writing guidelines which we should publics in few days... you couldn't know, this is why I explain here:
Anyway, great addition, you've your flower at the home page :) |
Add Prettier to Code Style Practices
…/add-huhgawz docs: add huhgawz as a contributor
No description provided.