Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove webpack public path for index.html #79 #88

Closed
wants to merge 3 commits into from
Closed

remove webpack public path for index.html #79 #88

wants to merge 3 commits into from

Conversation

darrylsepeda
Copy link

No description provided.

@darrylsepeda darrylsepeda mentioned this pull request Jun 15, 2017
Open
3 tasks
goldhand
goldhand requested changes Jun 15, 2017
View reviewed changes
Copy link
Owner

@goldhand goldhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is index.html the only file? I'm concerned about automatically treating index.html differently than all other webpack assets. I think it would be better to add an option to specify a regex that, when matching, does not prefix with the outputPath.

@darrylsepeda
Copy link
Author

darrylsepeda commented Jun 22, 2017 •
edited
Loading

thanks goldhand for the review, I realized that this PR not work.. but I've found other way to solve my case, I'll share on the issue page.

sorry I don't realized that you have reviewed and give comment to my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldhand goldhand goldhand requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrylsepeda @goldhand