Update wikipedia.py to fix suggestion in page function. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you tried to search for 'ireland' with the auto_suggest=True, the title was set to 'island' because the suggestion='island' and results[0]='ireland'. Thus suggestion or results[0] = suggestion. Shouldn't the expected behavior title be 'ireland' if you searched for 'ireland', even with auto_suggest=True. A small change but make a difference in my opinion. P.S. reversing the order doesn't work because of you made a spelling mistake, for instance 'ieland', the title will be set to something completely different, 'Jimmy MacCarthy' in that case. I that case you what the suggestion as the title, as in that example the suggestion is actually 'ireland'.
konmenel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you tried to search for 'ireland' with the auto_suggest=True, the title was set to 'island' because the suggestion='island' and results[0]='ireland'. Thus suggestion or results[0] = suggestion. Shouldn't the expected behavior title be 'ireland' if you searched for 'ireland', even with auto_suggest=True. A small change but make a difference in my opinion.
P.S. reversing the order doesn't work because of you made a spelling mistake, for instance 'ieland', the title will be set to something completely different, 'Jimmy MacCarthy' in that case. I that case you what the suggestion as the title, as in that example the suggestion is actually 'ireland'.