This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
version command reports build time VERSION env or Cargo.toml version #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfilip
changed the title
adrianfilip
force-pushed
the
report_version_used_at_build
branch
from
55c2f2c
to
b4cdba3
Compare
needed for artifact version update version command returns build time VERSION env or Cargo.toml version
adrianfilip
force-pushed
the
report_version_used_at_build
branch
from
b4cdba3
to
d9ea54b
Compare
adrianfilip
changed the title
adrianfilip
changed the title
adamgfraser
approved these changes
Feb 18, 2024
senia-psm
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
golem-cli --versionwill return that valuegolem-cli --versionwill return the build time version found in Cargo.tomlWhy?
Because, currently, builds outside of the CI always return 0.0.0 (the Cargo.toml default)
This is helpful for things like creating a nix package. (The current way of changing the Cargo.toml leads to hash differences in a nix context.)