Update and use forked golem repos #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the missing `jco types` subcommand to the README. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
…odealliance#444) * fix: don't overallocate string buffer while encoding into utf8 Recent dlmalloc-rs started validating that deallocation size is same as the size that was allocated. https://github.com/alexcrichton/dlmalloc-rs/blob/0.2.6/src/dlmalloc.rs#L1187 Since canonical abi string does not have "capacity" concept separate from "length", we don't have a way to tell how much memory was allocated to the buffer owner. So, canonical abi always assumes that "length" is the same as "capacity" and deallocates the buffer with the "length" size. This means that if we overallocate the buffer and return the buffer with a length less than the allocated size, dlmalloc-rs validation will fail. This commit fixes the issue by lopping off the extra allocated space by realloc with smaller size. * fix: call realloc exactly once for string encoding Previously, we would call realloc multiple times to grow the buffer and shrink it back down to the correct size. However, realloc provided by wasi-preview1-component-adapter is quite restrictive: * It can't always be called multiple times during a single imported function call. * It does not accept non-null old pointers. This commit changes the code to call realloc exactly once, which is compatible with those restrictions. The use of temporary buffers with `TextEncoder.encode` is less efficient than the previous `encodeInto`, but it allows us to keep the allocator in the adapter simple. We can optimize it after we will be able to get rid of the adapter or decide to complicate the allocator in the adapter.
vigoo
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ComponentizeJS PR and fork: golemcloud/ComponentizeJS#2
Published here: https://www.npmjs.com/package/@golemcloud/jco/v/1.2.4-golem.3