erc20: check deposit spender before balance

golemfactory · Jul 9, 2024 · fd88e85 · fd88e85
1 parent 36fe0d1
commit fd88e85
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/core/payment-driver/erc20/src/driver.rs b/core/payment-driver/erc20/src/driver.rs
@@ -466,6 +466,16 @@ impl Erc20Driver {
             deposit_spender,
         );
 
+        if allocation_address != deposit_spender {
+            log::debug!(
+                "Deposit validation failed, requested address [{}] doesn't match deposit spender [{}]",
+                allocation_address,
+                deposit_spender
+            );
+
+            return Ok(ValidateAllocationResult::DepositSpenderMismatch);
+        }
+
         if msg.amount > deposit_balance {
             log::debug!(
                 "Deposit validation failed: requested amount [{}] > deposit balance [{}]",
@@ -495,16 +505,6 @@ impl Erc20Driver {
             return Ok(ValidateAllocationResult::TimeoutExceedsDeposit);
         };
 
-        if allocation_address != deposit_spender {
-            log::debug!(
-                "Deposit validation failed, requested address [{}] doesn't match deposit spender [{}]",
-                allocation_address,
-                deposit_spender
-            );
-
-            return Ok(ValidateAllocationResult::DepositSpenderMismatch);
-        }
-
         Ok(ValidateAllocationResult::Valid)
     }
 }