Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable retry send_invoice #1296

Closed
nieznanysprawiciel opened this issue May 5, 2021 · 0 comments · Fixed by #1293
Closed

Enable retry send_invoice #1296

nieznanysprawiciel opened this issue May 5, 2021 · 0 comments · Fixed by #1293
Assignees
@nieznanysprawiciel
Labels
bug Something isn't working

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented May 5, 2021 •
edited by tworec
Loading

Why:

  • enable provider to retry call to send_invoice (it gives 50x on the second call)

What:

  • If invoice was already processed, requestor daemon should return valid GSB response
  • If send_invoice wasn't processed, requestor daemon should behave the same

Relates golemfactory/yagna-triage#100 and #1240
@nieznanysprawiciel nieznanysprawiciel changed the title Fix send_invoice Enable retry send_invoice May 5, 2021
@tworec tworec mentioned this issue May 5, 2021
Closed
@nieznanysprawiciel nieznanysprawiciel mentioned this issue May 5, 2021
Closed
@tworec tworec added beta.1.patch.5 bug Something isn't working labels May 5, 2021
@nieznanysprawiciel nieznanysprawiciel self-assigned this May 5, 2021
@nieznanysprawiciel nieznanysprawiciel linked a pull request May 6, 2021 that will close this issue
Payments - gateway timeout fix #1293
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nieznanysprawiciel nieznanysprawiciel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Payments - gateway timeout fix golemfactory/yagna
2 participants
@nieznanysprawiciel @tworec