Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect send_debit_note from 504 #1298

Closed
nieznanysprawiciel opened this issue May 5, 2021 · 1 comment
Closed

Protect send_debit_note from 504 #1298

nieznanysprawiciel opened this issue May 5, 2021 · 1 comment
Assignees
@maaktweluit @nieznanysprawiciel

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented May 5, 2021 •
edited by mateuszsrebrny
Loading

Why:

  • enable provider to survive 504 after send_debit_note fails
  • We need to sustain Agreements in case 504 issues

What:

  • Estimate severity
  • Check if the next DebitNote will be handled properly after 504 occures, while calling send_debit_note
  • Consider changing ya-provider logic, to behave to specially handle 504

Related to #1296
@nieznanysprawiciel nieznanysprawiciel changed the title Enable retry send_debit_note Protect send_debit_note from 504 May 5, 2021
@tworec tworec mentioned this issue May 5, 2021
Closed
1 task
@maaktweluit
Copy link
Contributor

We investigated and the send_debit_note can be re-send safely.
Also as far as we can see the agreement will not be terminated when this 504 happens.

We do see a an edge case where the accept_debit_note might fail, we made issue #1322 to follow up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maaktweluit maaktweluit

@nieznanysprawiciel nieznanysprawiciel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mateuszsrebrny @maaktweluit @nieznanysprawiciel