Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections to faucet are not closed. Out of file descriptors after long run. #760

Closed
etam opened this issue Nov 4, 2020 · 2 comments · Fixed by #770
Closed

Connections to faucet are not closed. Out of file descriptors after long run. #760

etam opened this issue Nov 4, 2020 · 2 comments · Fixed by #770
Labels
bug Something isn't working

Comments

@etam
Copy link
Contributor

etam commented Nov 4, 2020

Yagna version: https://github.com/golemfactory/yagna/tree/pre-rel-v0.4.1-fix-738 (50eda9e). It's basically 0.4.1 with some unrelated changes.

Steps to reproduce:

  • run yagna service
  • every 5 minutes call yagna payment init -r and request some computation

Result:
lsof -i -a -p <pid of yagna> -n -P | grep ":4000 (CLOSE_WAIT)" | wc -l reports a number growing over time.

@etam etam added the bug Something isn't working label Nov 4, 2020
@etam
Copy link
Contributor Author

etam commented Nov 4, 2020

after restart:

[...]
Nov 04 09:06:43 testnet-checker yagna[12499]: [2020-11-04T09:06:43Z INFO  ya_gnt_driver::gnt::sender] tx_hash=0xfd232599bba0f790e78ac76987b50b76130501da7042048e79bf066400c773f9, confirmations=27533
Nov 04 09:06:43 testnet-checker yagna[12499]: [2020-11-04T09:06:43Z INFO  ya_gnt_driver::gnt::sender] tx_hash=0x6beff1bc59a5d66731d9373b035ec81bd533285191b111922c6cb0aa14dcd601, confirmations=27533
Nov 04 09:06:43 testnet-checker yagna[12499]: [2020-11-04T09:06:43Z INFO  ya_gnt_driver::gnt::sender] tx_hash=0x18e73dff5350626b325b3d3254be0436395365d64fee28c18e0bcb6f23b4bdaa, confirmations=27533
Nov 04 09:06:44 testnet-checker yagna[12499]: [2020-11-04T09:06:44Z INFO  ya_gnt_driver::gnt] Notify payment: NotifyPayment { driver: "ngnt", amount: BigDecimal("0.06429042712555555"), sender: "0x324a880f4b4335543577e24b9d97b4d19cb6cec7", recipient: "0xf2bfe6456302c3667a
Nov 04 09:06:44 testnet-checker yagna[12499]: [2020-11-04T09:06:44Z INFO  ya_gnt_driver::gnt] Notify payment: NotifyPayment { driver: "ngnt", amount: BigDecimal("0.08015251312833332"), sender: "0x324a880f4b4335543577e24b9d97b4d19cb6cec7", recipient: "0x4c855a4bfb29ae37f2
Nov 04 09:06:44 testnet-checker yagna[12499]: thread 'main' panicked at 'assertion failed: `(left != right)`
Nov 04 09:06:44 testnet-checker yagna[12499]:   left: `0`,
Nov 04 09:06:44 testnet-checker yagna[12499]:  right: `0`', core/payment-driver/gnt/src/gnt/sender.rs:952:5
Nov 04 09:06:44 testnet-checker yagna[12499]: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Wiezzel added a commit that referenced this issue Nov 5, 2020
Previously used version (1.0.1) left open TCP connections.
Fixes #760

Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
@tworec
Copy link
Contributor

tworec commented Nov 10, 2020

I the past we've dealt with such errors by reusing awc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants