Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZkSync: Unlock wallet before withdrawal #1072

Merged
merged 1 commit into from
Feb 24, 2021
Merged

ZkSync: Unlock wallet before withdrawal #1072

merged 1 commit into from
Feb 24, 2021

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Feb 23, 2021 •
edited
Loading

Provider's wallet might not be unlocked when payment exit is being run. That would cause the command to fail. A call to unlock_wallet has been added to fix this.

Bonus: fixed glmSync transaction tracking link.

Testing instructions

ZkSync

  1. Run the service
$ cargo run service run
  1. Get some funds
$ cargo run payment fund
Received funds from the faucet. address=0x1264aee4168286ddf962c172a53e0e89a1562e44
  1. Withdraw
$ cargo run payment exit
Withdrawal has been accepted by the zkSync operator. It may take some time until the funds are available on Ethereum blockchain. Tracking link: https://rinkeby.zkscan.io/explorer/transactions/ebb12605a72ff4e080b8375e6b9cb77e18548bbbc1882cdb870d65c319907221
  1. Follow the link to check if withdrawal was successful.

GlmSync

  1. Run the service
$ export GLMSYNC_FAUCET_ADDR=http://yacn.dev.golem.network:5777/zk/donate
$ cargo run service run
  1. Get some funds
$ cargo run payment fund --driver=glmsync
Received funds from the faucet. address=0x1264aee4168286ddf962c172a53e0e89a1562e44
  1. Withdraw
$ cargo run payment exit --driver=glmsync
Withdrawal has been accepted by the zkSync operator. It may take some time until the funds are available on Ethereum blockchain. Tracking link: http://rinkeby.zksync.imapp.pl/explorer/transactions/f8c3d60f10dc6b1715104e28fb1f2445cfecb5617860fa34dc5cf36e95192758
  1. Follow the link to check if withdrawal was successful.

@Wiezzel
ZkSync: Unlock wallet before withdrawal
d33483e 
Provider's wallet might not be unlocked when `payment exit` is being
run. That would cause the command to fail. A call to `unlock_wallet`
has been added to fix this.

Bonus: fixed glmSync transaction tracking link.
Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
@Wiezzel Wiezzel added bug Something isn't working m-payment labels Feb 23, 2021
@Wiezzel Wiezzel self-assigned this Feb 23, 2021
@Wiezzel Wiezzel requested a review from a team February 23, 2021 15:15
maaktweluit
maaktweluit approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Wiezzel Wiezzel merged commit 1fd31c1 into release/v0.6 Feb 24, 2021
@Wiezzel Wiezzel deleted the wiezzel/zksync_exit_unlock branch February 24, 2021 10:56
@Wiezzel Wiezzel mentioned this pull request Feb 24, 2021
Merged
@maaktweluit
Copy link
Contributor

Bit later then expected, but tested OK 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaktweluit maaktweluit maaktweluit approved these changes

@pnowosie pnowosie pnowosie approved these changes

Assignees

@Wiezzel Wiezzel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wiezzel @maaktweluit @pnowosie