Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce payment signature validation #1671

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

maaktweluit
Copy link
Contributor

@maaktweluit maaktweluit commented Nov 4, 2021

Resolves #1654

In release v0.6 the payment signature verification was added.
To keep backwards compatibility this field was made optional.
Now we released v0.8 we can remove the "optional" part because all nodes 2 versions back include the signature.

@maaktweluit maaktweluit force-pushed the mwu/enforce-pay-validate branch from a6c4ba1 to 8027165 Compare November 5, 2021 11:34
@maaktweluit maaktweluit self-assigned this Nov 5, 2021
@maaktweluit maaktweluit marked this pull request as ready for review November 5, 2021 11:35
@maaktweluit maaktweluit requested a review from a team November 5, 2021 11:35
@maaktweluit maaktweluit changed the title Mwu/enforce pay validate Enforce payment signature validation Nov 5, 2021
@nieznanysprawiciel nieznanysprawiciel merged commit fc68d79 into master Nov 5, 2021
@nieznanysprawiciel nieznanysprawiciel deleted the mwu/enforce-pay-validate branch November 5, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove backward compatibility from payment signature verification
2 participants