Dynamic payment schema for polygon #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tworec
reviewed
Jan 5, 2022
tworec
reviewed
Jan 5, 2022
|
@scx1332 it would be great if you can describe the strategy introduced within this PR in few sentences (currently description is void, and it took me several minutes to get to the point) |
nieznanysprawiciel
previously approved these changes
Jan 5, 2022
| @@ -233,10 +260,15 @@ pub async fn send_transactions( | |||
| match serde_json::from_str::<YagnaRawTransaction>(&tx.encoded) { | |||
| Ok(raw_tx) => raw_tx, | |||
| Err(err) => { | |||
| let error = format!("JSON parse failed, unrecoverable error: {}", err); | |||
| log::error!("Error during serialization of json: {:?}", err); | |||
There was a problem hiding this comment.
This log has no context, where it happened. It will be hard to understand
… into scx1332/maticpayments
prekucki
previously approved these changes
Jan 5, 2022
nieznanysprawiciel
previously approved these changes
Jan 5, 2022
|
we are getting a lof of settings around gas.. would be nice to make it simpler instead of adding layers on top of layers of fixes |
scx1332
dismissed stale reviews from nieznanysprawiciel and prekucki
via
1e19c5c
nieznanysprawiciel
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.