Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSB API response payload any data type support #2636

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

pwalski
Copy link
Contributor

@pwalski pwalski commented Jun 26, 2023

Bugfix for GSB API making payload response field to support any data type, not only map

@pwalski
Copy link
Contributor Author

pwalski commented Jun 26, 2023

I created pre-rel-v0.13.0-rc6 to make easier testing the changes.

@pwalski
Copy link
Contributor Author

pwalski commented Jun 27, 2023

Included test covers case of RpcMessage with Item of unit type (()) - it was the unsupported case I needed to handle.
Every other type of response should work too, but I did not manage to test them.
Among them are:

@pwalski
Copy link
Contributor Author

pwalski commented Jun 27, 2023

It was implemented outside of scope of any task, and tests cover cases we are interested in.
Maybe we could merge it if SDK team app will start to work, and for additional tests we could create a task?

@pwalski pwalski marked this pull request as ready for review June 27, 2023 10:19
@pwalski pwalski requested a review from a team as a code owner June 27, 2023 10:19
@pwalski
Copy link
Contributor Author

pwalski commented Jun 28, 2023

SDK confirmed it solves the problem they faced.

@pwalski pwalski self-assigned this Jun 28, 2023
@pwalski pwalski enabled auto-merge (squash) June 28, 2023 12:01
@pwalski pwalski merged commit 3d8a9bb into master Jun 29, 2023
12 checks passed
@pwalski pwalski deleted the gsb_api_null_payload_issue branch June 29, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants