Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push metrics #762

Merged
merged 12 commits into from
Nov 6, 2020
Merged

Push metrics #762

merged 12 commits into from
Nov 6, 2020

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Nov 4, 2020

fixes: #720
fixes #747

core/metrics/src/service.rs Outdated Show resolved Hide resolved
core/metrics/src/service.rs Outdated Show resolved Hide resolved
core/metrics/src/metrics.rs Outdated Show resolved Hide resolved
core/metrics/src/metrics.rs Outdated Show resolved Hide resolved
core/metrics/src/metrics.rs Outdated Show resolved Hide resolved
core/metrics/src/service.rs Outdated Show resolved Hide resolved
core/metrics/src/service.rs Outdated Show resolved Hide resolved
core/metrics/src/service.rs Outdated Show resolved Hide resolved
@tworec
Copy link
Contributor

tworec commented Nov 4, 2020

add an configuration flag to disable metrics sending (we are sending them by default)

@tworec tworec marked this pull request as ready for review November 5, 2020 10:56
@jiivan jiivan changed the title [WIP] Push metrics Push metrics Nov 5, 2020
core/metrics/src/lib.rs Outdated Show resolved Hide resolved
core/serv-api/src/lib.rs Show resolved Hide resolved
tworec
tworec previously approved these changes Nov 6, 2020
core/metrics/src/pusher.rs Outdated Show resolved Hide resolved
@jiivan jiivan merged commit f8b70a1 into master Nov 6, 2020
@jiivan jiivan deleted the metrics-push branch November 6, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants