WIP TerminateAgreement endpoint #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| counter!("market.agreements.requestor.terminated", 1); | ||
| log::info!( | ||
| "Requestor {} terminated Agreement [{}] and sent to Provider.", | ||
| DisplayIdentity(&id), |
There was a problem hiding this comment.
Note for future: in #754 you can do id.display()
| Some(agreement) => agreement, | ||
| }; | ||
|
|
||
| Err(match agreement.state { |
There was a problem hiding this comment.
Just a note for future: We have such match on states in many places in code. Maybe we should refactor it somehow to remove duplication?
jiivan
force-pushed
the
market-decentralized/termag-ep
branch
3 times, most recently
from
4f12495 to
05ad9c0
Compare
|
@jiivan Your branch must begin with |
jiivan
force-pushed
the
market-decentralized/termag-ep
branch
from
05ad9c0 to
1aa89e7
Compare
…centralized/termag-ep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #727