Skip to content

Commit

Permalink
Code review: enable tests for PR's to b0.*; comments in pyproject.toml
Browse files Browse the repository at this point in the history
Co-authored-by: filipgolem <44880692+filipgolem@users.noreply.github.com>
Co-authored-by: Kuba Mazurek <jakub.mazurek@golem.network>
  • Loading branch information
3 people committed Mar 30, 2021
1 parent 03a79a7 commit dbe0f95
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
pull_request:
branches:
- master
- b0.*

jobs:

Expand Down
9 changes: 8 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,18 @@ toml = "^0.10.1"
srvresolver = "^0.3.5"
colorama = "^0.4.4"

# Adding `goth` to dependencies causes > 40 additional packages to be installed. Given
# that dependency resolution in `poetry` is rather slow, we'd like to avoid installing
# `goth` for example in a CI pipeline that only runs linters/unit tests, not integration
# tests. Therefore we specify `goth` as an "extra" dependency, with `optional = "true"`.
# It will be then installable with `poetry install -E integration-tests`.
# Note that putting `goth` in `poetry.dev-dependencies` instead of `poetry.dependencies`
# would not work: see https://github.com/python-poetry/poetry/issues/129.
goth = {git = "https://github.com/golemfactory/goth.git", branch = "master", optional = true, python = "^3.8.0"}

[tool.poetry.extras]
cli = ['fire', 'rich']
integration-tests = ['goth']
integration-tests = ['goth', 'pytest', 'pytest-asyncio']

[tool.poetry.dev-dependencies]
black = "^20.8b1"
Expand Down

0 comments on commit dbe0f95

Please sign in to comment.