Integration test for multi-activity agreement #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgolem
reviewed
Apr 27, 2021
| # may require more time for the first task if it needs to download a VM image | ||
| # first. Once downloaded, the VM image will be cached and other tasks that use | ||
| # that image will be computed faster. | ||
| yield ctx.commit(timeout=timedelta(minutes=10)) |
There was a problem hiding this comment.
The requestor will have to wait 10 minutes if any provider is broken (there are currently providers that are signing agreements and then doing nothing).
There was a problem hiding this comment.
True. But the problem with the timeout being too low is recurring and sometimes affects all providers (for example it happened after 0.6.3 yagna release, when many providers needed to refresh their VM images and were unable to do so for a long time since the activities were interrupted by our blender.py requestor due to 2 minute timeouts).
filipgolem
reviewed
Apr 27, 2021
| @@ -105,7 +105,7 @@ ya-market = "0.1.0" | |||
| [tool.poe.tasks] | |||
| test = "pytest --cov=yapapi --ignore tests/goth" | |||
| goth-assets = "python -m goth create-assets tests/goth/assets" | |||
| goth-tests = "pytest -svx tests/goth" | |||
| goth-tests = "pytest -svx tests/goth --config-override docker-compose.build-environment.release-tag=0.6." | |||
There was a problem hiding this comment.
Why is this parameter used?
There was a problem hiding this comment.
It's used to enforce using yagna release 0.6.x for the tests.
filipgolem
approved these changes
Apr 27, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an integration test case that uses
goth. It tests that multiple activities can be run within the same agreement.Other changes:
gothconfiguration values via command line (ported @zakaprov commit golemfactory/yagna@66b275c fromyagna); use it to forceyagnaversion to0.6.x.blender.py, to take into account the time needed to download the VM image.