Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blender example: do not overwrite blender example debug logs #352

Merged
merged 3 commits into from
Apr 29, 2021
Merged

blender example: do not overwrite blender example debug logs #352

merged 3 commits into from
Apr 29, 2021

Conversation

tworec
Copy link
Contributor

@tworec tworec commented Apr 27, 2021

Why:

  • we are over and over overwriting our logs with new ones

What:

  • add a simple timestamp to the log filename

@tworec tworec requested a review from a team April 27, 2021 14:58
@tworec tworec force-pushed the do-not-overwrite-blender-logs branch from 836189b to 00baca9 Compare April 27, 2021 14:59
@tworec tworec force-pushed the do-not-overwrite-blender-logs branch from 00baca9 to 7dc2cf4 Compare April 27, 2021 15:00
maaktweluit
maaktweluit approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewrite is finally over ;)

azawlocki
azawlocki approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tworec tworec merged commit e152aa2 into b0.5 Apr 29, 2021
@tworec tworec deleted the do-not-overwrite-blender-logs branch April 29, 2021 10:14
@tworec tworec mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

@maaktweluit maaktweluit maaktweluit approved these changes

Assignees
No one assigned
Labels
beta.1.patch.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tworec @azawlocki @maaktweluit @mateuszsrebrny