Replace message in events.CommandExecuted with stdout and stderr
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
reviewed
May 18, 2021
| kwargs["command"] = cmds[self.kwargs["cmd_idx"]] | ||
| kwargs["stdout"] = kwargs["stderr"] = None | ||
| try: | ||
| # Replace the "message" kwarg with "stdout" and "stderr" |
There was a problem hiding this comment.
hmm.... is this by design that we're allowing arbitrary other keyword arguments to pass through this function?
There was a problem hiding this comment.
Well, I'm not the original author of this piece of code but I guess the reason for that is that kwargs are used to provide arguments for calls to evt_cls.__init__(), where evt_cls is some subclass of CommandEvent known only at runtime. So it's not possible to specify statically which kwargs should be allowed.
shadeofblue
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #377