Yield completed tasks from Engine.map()
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
commented
Sep 24, 2020
yapapi/runner/__init__.py
Outdated
| @@ -329,7 +324,7 @@ async def find_offers(): | |||
| await proposal.respond(builder.props, builder.cons) | |||
| emit(Event.ProposalResponded(prop_id=proposal.id)) | |||
| except Exception as ex: | |||
| emit(Event.ProposalFailed(sub_id=subscription.id, reason=str(ex))) | |||
| emit(Event.ProposalFailed(prop_id=proposal.id, reason=str(ex))) | |||
There was a problem hiding this comment.
This error has been reported by mypy but only after I added a return type annotation to def find_offers().
azawlocki
commented
Sep 24, 2020
yapapi/runner/__init__.py
Outdated
| @@ -409,8 +404,8 @@ async def worker_starter(): | |||
| task = None | |||
| try: | |||
| agreement = await b.proposal.agreement() | |||
| provider_id = (await agreement.details()).view_prov(Identification) | |||
| emit(Event.AgreementCreated(agr_id=agreement.id, provider_id=provider_id)) | |||
| prov_idn = (await agreement.details()).view_prov(Identification) | |||
There was a problem hiding this comment.
provider_id = ... shadowed another declaration with a different type
azawlocki
commented
Sep 24, 2020
| ): | ||
| if datetime.now(timezone.utc) > self._expires: | ||
| raise TimeoutError(f"task timeout exceeded. timeout={self._conf.timeout}") | ||
|
|
||
| if not get_done_task: | ||
| get_done_task = loop.create_task(done_queue.get()) |
There was a problem hiding this comment.
This (asyncio) task just removes a single completed (yapapi) task from done_queue.
azawlocki
commented
Sep 24, 2020
| @@ -508,113 +516,11 @@ async def __aexit__(self, exc_type, exc_val, exc_tb): | |||
| await self._stack.aclose() | |||
|
|
|||
|
|
|||
| class TaskStatus(Enum): | |||
There was a problem hiding this comment.
This code has been moved to yapapi/runner/task.py
azawlocki
force-pushed
the
refactor/typed-events
branch
2 times, most recently
from
e9a2310
to
d005c4d
Compare
azawlocki
force-pushed
the
refactor/yield-completed-tasks
branch
from
57d6ef3
to
1d477a9
Compare
filipgolem
approved these changes
Sep 30, 2020
azawlocki
force-pushed
the
refactor/yield-completed-tasks
branch
2 times, most recently
from
8b6de25
to
89226f5
Compare
azawlocki
force-pushed
the
refactor/yield-completed-tasks
branch
from
89226f5
to
fc2ed6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Engine.map()now yields completed tasks. Its return type is nowAsyncIterator[Task[D, R]], whereDandRare type variables representing task data and results, respectively.The
Taskclass is in a separate moduleyapapi.runner.task.