Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for filtering provider offers by golem.inf.cpu.threads #508

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Support for filtering provider offers by golem.inf.cpu.threads #508

merged 4 commits into from
Jul 2, 2021

Conversation

filipgolem
Copy link
Contributor

No description provided.

@filipgolem filipgolem requested review from azawlocki and a team July 1, 2021 09:21
shadeofblue
shadeofblue reviewed Jul 1, 2021
View reviewed changes
yapapi/payload/vm.py Outdated Show resolved Hide resolved
shadeofblue
shadeofblue previously requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please simplify the name of the vm.repo parameter

@azawlocki azawlocki mentioned this pull request Jul 2, 2021
Merged
@filipgolem filipgolem self-assigned this Jul 2, 2021
azawlocki
azawlocki approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipgolem filipgolem dismissed shadeofblue’s stale review July 2, 2021 10:00

The parameter name was simplified.

@filipgolem filipgolem merged commit 1d28985 into master Jul 2, 2021
@filipgolem filipgolem deleted the cpu-cores-constraints branch July 2, 2021 10:01
filipgolem added a commit that referenced this pull request Jul 2, 2021
@filipgolem
Support for filtering provider offers by golem.inf.cpu.threads (#508)
7983be5
filipgolem added a commit that referenced this pull request Jul 2, 2021
@filipgolem
Reduce log spam and min cpu threads to b0.6 (#512)
cdb5825 
* Reduce log entries related to confirmed proposals (#505)
* Support for filtering provider offers by golem.inf.cpu.threads (#508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

@shadeofblue shadeofblue Awaiting requested review from shadeofblue

Assignees

@filipgolem filipgolem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipgolem @azawlocki @shadeofblue