Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respawn instances that failed in starting state #509

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

azawlocki
Copy link
Contributor

Resolves #392

This PR makes Cluster spawn a new instance, if previously created instance fails in starting state. If an instance reaches its running state and then fails, no new instance will be spawned.

Re-spawning instances can be suppressed -- for a wholeCluster -- by passing respawn_unstarted_instances=False in a call to Golem.run_service() that creates the Cluster.

@azawlocki azawlocki requested a review from a team July 1, 2021 10:02
@azawlocki azawlocki self-assigned this Jul 1, 2021
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) ...

the only thing that I'm wondering about is whether maybe we should place this requestor.py in the examples ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants