Use command_index when calling get_exec_batch_results #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgolem
commented
Jul 15, 2021
filipgolem
commented
Jul 17, 2021
filipgolem
commented
Jul 17, 2021
azawlocki
reviewed
Jul 18, 2021
| @@ -77,9 +77,9 @@ async def test_run_blender( | |||
| await all_sent.wait_for_result(timeout=120) | |||
| logger.info("All tasks sent") | |||
|
|
|||
| await all_computed.wait_for_result(timeout=30) | |||
| await all_computed.wait_for_result(timeout=120) | |||
There was a problem hiding this comment.
I'm not sure this change is okay, the time between the moment the last task is sent and the moment the last task is computed should not be that long.
There was a problem hiding this comment.
I know, but it seems that sometimes it takes more than 30s to render the image and send it back. I had to run the test again multiple times without this change.
azawlocki
reviewed
Jul 18, 2021
| logger.info("All tasks sent") | ||
|
|
||
| await all_computed.wait_for_result(timeout=60) | ||
| await all_computed.wait_for_result(timeout=120) |
There was a problem hiding this comment.
See my comment for test_run_blender.py.
azawlocki
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.