Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOTH] Renegotiate proposal #551

Merged
merged 6 commits into from
Aug 3, 2021
Merged

[GOTH] Renegotiate proposal #551

merged 6 commits into from
Aug 3, 2021

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Jul 20, 2021 •
edited
Loading

@jiivan jiivan force-pushed the goth_renegotiate_proposal branch from 5b58e35 to cdb6e00 Compare July 20, 2021 15:56
@jiivan jiivan marked this pull request as ready for review July 28, 2021 13:13
@jiivan jiivan requested a review from a team July 28, 2021 13:13
kmazurek
kmazurek reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@kmazurek kmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test currently fails while waiting on agreement.terminate(): True to appear in the requestor agent logs. I merged with latest master to include some improvements to how timeout errors are reported.

I also found the provider agents have the following panic in their logs: thread 'main' panicked at 'not implemented', agent/provider/src/market/provider_market.rs:247:14

tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
tests/goth_tests/test_renegotiate_proposal/requestor.py Outdated Show resolved Hide resolved
jiivan and others added 3 commits August 2, 2021 16:36
@jiivan
Copy link
Contributor Author

jiivan commented Aug 2, 2021 •
edited
Loading

The test currently fails while waiting on agreement.terminate(): True to appear in the requestor agent logs. I merged with latest master to include some improvements to how timeout errors are reported.

I also found the provider agents have the following panic in their logs: thread 'main' panicked at 'not implemented', agent/provider/src/market/provider_market.rs:247:14

That's perfect! 👌 It failed because Ci run on a pre-fix version of yagna. Today (after release) it passes :)

@kmazurek kmazurek mentioned this pull request Aug 2, 2021
Merged
@jiivan jiivan merged commit ca29e0f into master Aug 3, 2021
@jiivan jiivan deleted the goth_renegotiate_proposal branch August 3, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmazurek kmazurek kmazurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GOTH test for renegotiating proposals
3 participants
@jiivan @kmazurek @tworec