Port to embedded-hal 1.0.0-rc.1 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I don't do a lot with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rppal to embedded-hal 1.0.0-rc.1.
That is currently the latest released version. (This version is also implemented by esp-idf-hal. Which is good for portability of drivers between rppal and esp)
I tested SPI and I2C communication with rppal on a Raspi 2 with an adxl345 device.
Note:
embedded-hal now suggests to implement the embedded-io traits for uart.
See https://docs.rs/embedded-hal/1.0.0-rc.1/embedded_hal/index.html#serialuart-traits
This is not done with this PR, yet. That can be done later, if required.