-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rabbitmq): add custom logger to configuration #401
feat(rabbitmq): add custom logger to configuration #401
Conversation
LGTM, @WonderPanda Any thoughts on this? |
Any update on that? |
All the integration tests seem to be failing, we'll need to look into this before the PR can be merged |
@WonderPanda do you have any idea why the tests are failing? |
A new e2e test I wrote was failing... I changed that. |
@AdrienEtienne The tests seem to be stable and pass now, can you just check the unsafety that's reported on CI nodejs 17? Once that passes, I'm okay to merge |
Ok thanks. The tests are failing randomly when I run those locally. I changed the test on the custom logger, got no error with node v17. |
Description
This PR is about adding a custom logger, implementing the
LoggerService
interface from NestJS.What is done
We pass the logger directly into the configuration object.
Missing \ Improvements
Currently the class
RabbitMQModule
is still using the default logger. I didn't found a way to pass a custom logger from the configuration. Help would be appreciated :).Related PRs
This PR is about allowing to set log level to verbose: #264
I think it is a better solution to just pass a custom logger to the module.