-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rabbitmq): add verbose logging #264
Conversation
Add verbose logging arround the message handling, this makes debugging issues easier
@arjenvdhave For some reason this is breaking the integration tests: I'm not sure at a glance yet why this change would have that affect but we will need to figure it out before this can be merged through |
@WonderPanda i managed to reproduce the error local With a I tried to set the log level in the NestJS testing module, but this doesn't seem to do anything. Do you think i should add an option |
@arjenvdhave I do think it is a really good idea for us to have some kind of official hook for people to be able to do verbose logging. Its super useful for diagnostics. I'm open to adding an option to the module configuration to turn on logging but I'm very curious about why adding a log statement would produce this kind of issue and want to make sure that it doesn't indicate something else wrong going on |
@WonderPanda I will continue with it next week and make it an option. I will try putting it in an async method and see what will happen to the test speed then. |
@arjenvdhave Adding a verbose logging option seems reasonable to me, having this by default can pollute existing applications that are happy with the current logging. If this is still relevant, could we have an update? |
@underfisk I think this is still a good addition to the lib. The product im working on has moved away from RabbitMQ, so i don't have a working setup now anymore. |
I can investigate why they were failing, i just wanted to make sure this is something worth diving in |
@arjenvdhave There's a new PR that has been merged recently that allows you to provide a custom logger therefore you can customize your logs |
Add verbose logging arround the message handling, this makes debugging issues easier