Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hasura): metadata v3 support #284

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

WonderPanda
Copy link
Collaborator

@WonderPanda WonderPanda commented Jul 1, 2021

Improvements

Adds support for the new metadata v3 format

Todo Before Merge

  • Add tests for v2 metadata to ensure we don't break things for existing users
  • Add tests for cron events

@WonderPanda
Copy link
Collaborator Author

@BraunreutherA If you feel like having a look

@BraunreutherA
Copy link

@WonderPanda thanks for your work on this. Very well implemented!

@BraunreutherA
Copy link

Is there a reason why the test fixtures are in the .gitignore? I think then we would have to generate them on every test run.

@WonderPanda
Copy link
Collaborator Author

Is there a reason why the test fixtures are in the .gitignore? I think then we would have to generate them on every test run.

@BraunreutherA If they are not added to .gitignore then they will generate changes to the repo everytime someone runs the tests. I feel like it would be confusing for people pulling down the codebase if they have a fresh copy of the repo and then run tests and see a whole bunch of changes in git.

I've updated the logic to properly copy over the .tmpl files at test startup

@WonderPanda WonderPanda merged commit bcb6fc6 into master Jul 6, 2021
@WonderPanda WonderPanda deleted the feat/hasura-metadata-v3 branch July 6, 2021 12:21
@WonderPanda WonderPanda mentioned this pull request Jul 6, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants